[TIMOB-20589] iOS: Allow editing contacts in iOS9 and above #7870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| #pragma mark - TiContactsPersonUpdateObserver | ||
| - (void)didUpdatePerson:(TiContactsPerson*)person { | ||
| saveRequest = saveRequest?saveRequest:[CNSaveRequest new]; |
sriks
force-pushed
the
TIMOB-20589-master
branch
from
178caff
to
b5aa8f0
Compare
sriks
force-pushed
the
TIMOB-20589-master
branch
from
b5aa8f0
to
83fe7b8
Compare
|
@hansemannn addressed review comments. |
| if (self = [super _initWithPageContext:context]) { | ||
| person = [person_ retain]; | ||
| if (![person_ isMemberOfClass:[CNMutableContact class]]) |
…uring when setting single value
|
CR and FT passed. APPROVED. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-20589
[TIMOB-20589] iOS: Allow editing contacts in iOS9 and above
Optional Description:
Provides mutable TiContactPerson objects.