[TIMOB-20337] Parity: enabling run-on-main-thread #7878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shouldn't we still support and deprecate the old way first? |
|
It's ok. When it was introduced earlier, it was already mentioned that it's experimental so there should not be any project dependencies on this. |
|
Would be cool to just throw a log-warning once and remove that for 6.0.0 so everyone know's what's going on. |
|
Sounds reasonable. Will update pr |
| @@ -35,6 +34,7 @@ | |||
| <property name="ti.bb.invoke.target.key.push" type="string">ti.testapp.invoke.push</property> | |||
| <property name="ti.bb.invoke.target.key.open" type="string">ti.testapp.invoke.open</property> | |||
| <property name="push_title" type="string">Some Title for BB Push, typically the app name"</property> | |||
| <property name="run-on-main-thread" type="bool">true</property> | |||
| <code-processor> | |||
| @@ -2076,7 +2076,14 @@ iOSBuilder.prototype.initialize = function initialize() { | |||
| // Remove the debugHost/profilerHost check when we have debugging/profiling support with JSCore framework | |||
| // TIMOB-17892 | |||
| this.currentBuildManifest.useJSCore = this.useJSCore = !this.debugHost && !this.profilerHost && (this.tiapp.ios['use-jscore-framework'] || false); | |||
| this.currentBuildManifest.runOnMainThread = this.runOnMainThread = (this.tiapp['run-on-main-thread'] === true); | |||
| // Remove this check on 6.0.0 | |||
| if(this.tiapp.ios && (this.tiapp.ios.hasOwnProperty('run-on-main-thread'))) { | |||
There was a problem hiding this comment.
there should a space between if and (
|
Looks good. Approved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-20337