Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-23116] iOS: Add session identifiers to urlSession events #7889

Merged
merged 4 commits into from Mar 28, 2016
Merged

[TIMOB-23116] iOS: Add session identifiers to urlSession events #7889

merged 4 commits into from Mar 28, 2016

Conversation

hansemannn
Copy link
Collaborator

JIRA: https://jira.appcelerator.org/browse/TIMOB-23116

Thank you @axmo for the initial PR (#6941). I added:

  • Nil-validations for the case that the sessionIdentifier is nil
  • The docs for the new property, as well as the docs for the uploadprogress event
  • The missing dictionary in URLSessionDidFinishEventsForBackgroundURLSession.
  • The corresponding JIRA-ticket

@hansemannn hansemannn mentioned this pull request Mar 27, 2016
Closed
AngelkPetkov
AngelkPetkov reviewed Mar 28, 2016
View reviewed changes
apidoc/Titanium/App/iOS/iOS.yml
header was not provided, the value is zero.
type: Number
osver: {ios: {min: "7.0"}}
since: "3.2.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im guessing this was always in the code but missed from the docs ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, since 3.2.0

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, awesome :)

@AngelkPetkov
Copy link
Contributor

Approved , merging!

@AngelkPetkov AngelkPetkov merged commit 7e4b4a6 into tidev:master Mar 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hansemannn @AngelkPetkov @axmo