32238 loss of precision set double #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -79,16 +79,24 @@ public class TiProperties | |||
| if (DBG) { | |||
| Log.d(LCAT,"getDouble called with key:"+key+", def:"+def); | |||
| } | |||
| return (double)preferences.getFloat(key,(float)def); | |||
| if( !this.hasProperty(key) ) | |||
There was a problem hiding this comment.
We generally use spaces after if , and none inside the condition, but I'll update this when I merge
|
Code review, functional test. Accepted. (Formatting changes and drillbit test will be added by Marshall before merging) |
|
Functional test looks good, some minor code review nits that I'll be fixing up when I merge in. Thanks for this! |
alexandergalstyan
referenced
this pull request
in alexandergalstyan/titanium_mobile
Jun 25, 2012
TIMOB-9164: Blackberry: [Studio integration] regenerate the bar-descriptor file at packaging time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Casting down to float causes loss of precision, better to store as string and convert to double for the getter.