Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-20116] [TIMOB-23134] Android: IndexOutOfBoundsException in ScrollableView removeView() #7904

Merged
merged 6 commits into from Apr 5, 2016

Conversation

falkolab
Copy link
Contributor

@falkolab falkolab commented Apr 1, 2016

@hansemannn
Copy link
Collaborator

Can you check your Atom editor settings before? It produces white spaces. Thanks!

@falkolab
Copy link
Contributor Author

falkolab commented Apr 1, 2016

Where you find it? Studio produces tabs in blank lines and trailing spaces but not Atom.

@falkolab
Copy link
Contributor Author

falkolab commented Apr 1, 2016

This is white spaces specs http://www.oracle.com/technetwork/java/javase/documentation/codeconventions-141388.html#475
What wrong with my PR?

@falkolab falkolab changed the title [Android] IndexOutOfBoundsException in ScrollableView removeView() [TIMOB-20116] [TIMOB-23134] Android: IndexOutOfBoundsException in ScrollableView removeView() Apr 1, 2016
@m1ga
Copy link
Contributor

m1ga commented Apr 1, 2016

@falkolab about the whitespace problem: https://discuss.atom.io/t/atom-changes-lines-that-i-havent-touched-so-git-finds-changes-that-arent-really-changes/11224

e.g. line 47 has no code change but it shows a diff.

@falkolab
Copy link
Contributor Author

falkolab commented Apr 1, 2016

I added whitespaces but don't know what are they needed for and I can't find any specifications about. =)

@hansemannn
Copy link
Collaborator

It's fine for now, thank you @falkolab!

@ashcoding
Copy link
Contributor

Code reviewed and functionally tested with https://jira.appcelerator.org/browse/TIMOB-23134 and https://jira.appcelerator.org/browse/TIMOB-20116.
Approved Merging.

@ashcoding ashcoding merged commit c363373 into tidev:master Apr 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants