[TIMOB-16512] Android: added padding to TextField #7908

m1ga · 2016-04-02T14:38:53Z

JIRA: https://jira.appcelerator.org/browse/TIMOB-16512

Updating the #5492 PR so can be used with the current branch again. All the credit goes to @bijupmb .

hansemannn · 2016-04-02T14:49:20Z

Please add docs, thanks!

hansemannn · 2016-04-03T19:07:14Z

Thank you. Please also add the since: "5.4.0" key so people now since when it's available. For the properties that are already available on iOS, you can check this example on how the syntax works.

hansemannn · 2016-04-06T11:51:11Z

Will FT now and merge, looks all good! Maybe we should think of moving the padding to a more clean way (on both iOS and Android) with something like this:

var field = Ti.UI.createTextField({
    padding: {
        left: 10,
        right: 10,
        top: 10,
        bottom: 10
    }
});

Does that make sense to you? So we would handle it like we do with listSeparatorInsets and other "bounds-like" API's. But that should be covered in a separate ticket.

m1ga · 2016-04-06T18:08:56Z

@hansemannn sounds like a good idea and looks better. Should I change it for this PR or leave it like this for the moment so it's the same on iOS?

hansemannn · 2016-04-06T18:10:07Z

Let's leave like it is for now and I'll file a ticket for it the next days. Thanks!

hansemannn · 2016-04-16T13:29:02Z

You know what, let's do that change in this PR, I will setup one for iOS and we merge both for 5.4.0. Otherwise, we would change and deprecate the whole thing in 5.5.0 / 6.0.0 again and that produces even more work.

m1ga · 2016-04-16T13:30:41Z

Ok, I'll get the android part ready

m1ga · 2016-04-16T14:11:33Z

Changed it ;) I've added ios,ipad in the documentation already

hansemannn · 2016-04-25T07:43:40Z

apidoc/Titanium/UI/TextField.yml

+
+  - name: bottom
+    type: Number
+    summary: Bottom padding


iOS only allows left and right padding because an input should always be vertically centered. We should consider doing the same with Android, so we don't need to handle different behaviors across platforms. Also please deprecate the old properties.

Done!

syntex: padding: {left:10,right:10}

updated example on jira

TextArea will still be TOP/LEFT, TextField is always vertically aligned

hansemannn · 2016-04-26T09:18:51Z

Alright! Now you decide: Are you fine with me cherry-picking your commits and setup a new PR including iOS and Android to have the platforms combinded in one PR, or do you want me to merge yours first and setup another one? 😊

m1ga · 2016-04-26T10:35:29Z

See ti-slack: if its less work with cherry-picking feel free to create a new PR with iOS and Android!

ashcoding · 2016-05-04T03:57:08Z

Tested and reviewed this with app.js

var win =  Ti.UI.createWindow({
    layout: "vertical",
    backgroundColor: "#fff"
});

var t1 =  Ti.UI.createTextField({
    value: "lllllllllmmmmmmmmmmmmmmlllllllllll",
    padding: {
        left: 20,
        right: 0
    },
    width: 100,
    height: Ti.UI.SIZE,
    borderColor: "#000",
    color: "#000",
    borderWidth: 1,
    top: 10
});


var t2 = Ti.UI.createTextField({
    value: "lllllllllmmmmmmmmmmmmmmlllllllllll",
    padding: {
        right: 20,
        left: 0
    },
    width: 100,
    height: Ti.UI.SIZE,
    borderColor: "#000",
    color: "#000",
    borderWidth: 1,
    top: 10
});

var t3 = Ti.UI.createTextField({
    value: "lllllllllmmmmmmmmmmmmmmlllllllllll",
    padding: {
        left: 20,
        right: 20
    },
    width: 100,
    height: Ti.UI.SIZE,
    borderColor: "#000",
    color: "#000",
    borderWidth: 1,
    top: 10
});

var t4 = Ti.UI.createTextField({
    value: "lllllllllmmmmmmmmmmmmmmlllllllllll",

    width: 100,
    height: 100,
    borderColor: "#000",
    color: "#000",
    borderWidth: 1,
    top: 10
});


win.add(t1);
win.add(t2);
win.add(t3);
win.add(t4);

win.open();

t4.padding = {left: 50, right: 50};

Code working fine and looks good.
@hansemannn I assume that you are preparing iOS PR for parity?
We need to do either:-
a) Cherry-pick this and put it in your iOS PR and update the docs for 6.0.0 ( Cause we are close to freezing for 5.4.0 ) and merge this for 6.0.0
b) Merge this with iOS PR soon.

Is there a link for iOS PR?

ashcoding · 2016-05-04T07:07:51Z

I think we should push this for 6.0.0. That way, we won't need to rush this. @hansemannn
We can update the docs later.

ashcoding · 2016-05-04T08:44:45Z

Code reviewed and tested. Approved
Will leave it to @hansemannn to merge when he gets the iOS portion in.

hansemannn · 2016-05-05T19:22:46Z

apidoc/Titanium/UI/TextArea.yml

+        since: "5.4.0"
+        notes: Use padding instead    
+
+  - name: paddingRight


So paddingLeft and paddingRight haven't been documented for Ti.UI.TextArea before? EDIT: It haven't been available for iOS before, so we don't need to deprecate it.

So paddingLeft and paddingRight haven't been documented for Ti.UI.TextArea before?

ashcoding · 2016-05-06T03:45:25Z

Just a note, this will be for 6.0.0.

hieupham007 · 2016-05-25T22:23:36Z

android/modules/ui/src/java/ti/modules/titanium/ui/widget/TiUIText.java

+		int paddingRight = 0;
+
+		if (d.containsKey(TiC.PROPERTY_LEFT)) {
+			paddingLeft = TiConvert.toInt(d, TiC.PROPERTY_LEFT);


Please use TiConvert methods that with a fall back default in case the input is invalid like null and such. Something like this TiConvert.toInt(d, TiC.PROPERTY_LEFT, someDefaultValue).

hieupham007 · 2016-05-25T22:23:43Z

android/modules/ui/src/java/ti/modules/titanium/ui/widget/TiUIText.java

+			paddingLeft = tv.getPaddingLeft();
+		}
+		if (d.containsKey(TiC.PROPERTY_RIGHT)) {
+			paddingRight = TiConvert.toInt(d, TiC.PROPERTY_RIGHT);


ashcoding · 2016-06-07T08:54:49Z

@hieupham007 This looks like it's good to go.

ashcoding · 2016-06-27T07:11:06Z

Merging

build · 2016-06-27T07:11:08Z

Can one of the admins verify this patch?

m1ga · 2016-11-16T18:46:28Z

@hansemannn was the iOS part merged into 6.0.0? I've tried to set padding: {left:10,right:10} to a TextField today and it wasn't working. If its not in the documentation needs to be changed

hansemannn · 2016-11-16T19:06:59Z

@m1ga Not, yet. Updated in 3f0bb97

m1ga · 2016-11-16T19:08:00Z

👍

jpriebe · 2018-01-17T17:14:13Z

It looks like this never got merged. Is it ever going to get merged?

Is there any reason that top/bottom padding isn't included in this PR, the way it is in #5492 ?

BTW -- there's a typo in TextField.yml (3f0bb97) - "descrioption" instead of "description"

hansemannn · 2018-01-17T17:18:17Z

@jpriebe This PR was merged on June 26 2016 (see above). For the typo: It is not actually an issue as later commits made the API cross-platform, making the description obsolet. For the top/bottom: Maybe @m1ga knows more about that.

m1ga · 2018-01-17T17:20:46Z

@jpriebe see this comment: #7908 (comment)
it is because of parity reasons. I've added top/bottom to but removed since it is not part of iOS.

jpriebe · 2018-01-17T18:38:44Z

Thanks, guys. I was mistakenly looking at TiUIEditText instead of TiUIText.

After some experimentation, I have been able to get padding to work on android, but I have found that vertical padding of 0 doesn't really mean 0 from a visual standpoint. It looks like there is about 12dp of padding on top and bottom that can't be removed. That was leading me to believe that padding didn't work.

When you try to set the size of a text field to something slightly smaller than the default (e.g. 30dp), the padding remains, and the text is cut off.

I guess the bottom line is that there's no way to create a compact TextField on android. (I know, it violates all sorts of usability guidelines to create something that small, but I think there are some legitimate applications.

added padding to textfields

dbfd5d9

hansemannn mentioned this pull request Apr 2, 2016

[TIMOB-16512] Android: added left and right padding to TextField #5492

Closed

hansemannn added android community 🔥 improvement labels Apr 2, 2016

docs

8acb13a

hansemannn added feature and removed improvement labels Apr 2, 2016

adding 'since'

7ffe43c

m1ga added 2 commits April 16, 2016 15:56

change to padding hashmap

633405f

docs

5b689eb

hansemannn reviewed Apr 25, 2016
View reviewed changes

m1ga added 2 commits April 25, 2016 18:54

remove top/bottom. Deprecate old ios values. Change documentation

16a649f

only vertically align textfield. docu for textarea

a1f424c

hansemannn reviewed May 5, 2016
View reviewed changes

hieupham007 reviewed May 25, 2016
View reviewed changes

m1ga added 2 commits May 26, 2016 01:09

updated version, default values

024aff7

fixed default values

f6b589d

hansemannn added the 6.0.0 label May 31, 2016

sgtcoolguy modified the milestone: 6.0.0 Jun 17, 2016

sgtcoolguy removed the 6.0.0 label Jun 17, 2016

ashcoding merged commit 5da41d7 into tidev:master Jun 27, 2016

m1ga deleted the android_padding branch June 28, 2016 20:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TIMOB-16512] Android: added padding to TextField #7908

[TIMOB-16512] Android: added padding to TextField #7908

m1ga commented Apr 2, 2016

hansemannn commented Apr 2, 2016

hansemannn commented Apr 3, 2016

hansemannn commented Apr 6, 2016

m1ga commented Apr 6, 2016

hansemannn commented Apr 6, 2016

hansemannn commented Apr 16, 2016

m1ga commented Apr 16, 2016

m1ga commented Apr 16, 2016

hansemannn Apr 25, 2016

m1ga Apr 25, 2016

m1ga Apr 25, 2016

hansemannn commented Apr 26, 2016

m1ga commented Apr 26, 2016

ashcoding commented May 4, 2016

ashcoding commented May 4, 2016

ashcoding commented May 4, 2016

hansemannn May 5, 2016 •

edited

hansemannn May 5, 2016

hansemannn May 5, 2016

ashcoding commented May 6, 2016

hieupham007 May 25, 2016

hieupham007 May 25, 2016

ashcoding commented Jun 7, 2016

ashcoding commented Jun 27, 2016

build commented Jun 27, 2016

m1ga commented Nov 16, 2016

hansemannn commented Nov 16, 2016

m1ga commented Nov 16, 2016

jpriebe commented Jan 17, 2018

hansemannn commented Jan 17, 2018

m1ga commented Jan 17, 2018

jpriebe commented Jan 17, 2018 •

edited

[TIMOB-16512] Android: added padding to TextField #7908

[TIMOB-16512] Android: added padding to TextField #7908

Conversation

m1ga commented Apr 2, 2016

hansemannn commented Apr 2, 2016

hansemannn commented Apr 3, 2016

hansemannn commented Apr 6, 2016

m1ga commented Apr 6, 2016

hansemannn commented Apr 6, 2016

hansemannn commented Apr 16, 2016

m1ga commented Apr 16, 2016

m1ga commented Apr 16, 2016

hansemannn Apr 25, 2016

Choose a reason for hiding this comment

m1ga Apr 25, 2016

Choose a reason for hiding this comment

m1ga Apr 25, 2016

Choose a reason for hiding this comment

hansemannn commented Apr 26, 2016

m1ga commented Apr 26, 2016

ashcoding commented May 4, 2016

ashcoding commented May 4, 2016

ashcoding commented May 4, 2016

hansemannn May 5, 2016 • edited

Choose a reason for hiding this comment

hansemannn May 5, 2016

Choose a reason for hiding this comment

hansemannn May 5, 2016

Choose a reason for hiding this comment

ashcoding commented May 6, 2016

hieupham007 May 25, 2016

Choose a reason for hiding this comment

hieupham007 May 25, 2016

Choose a reason for hiding this comment

ashcoding commented Jun 7, 2016

ashcoding commented Jun 27, 2016

build commented Jun 27, 2016

m1ga commented Nov 16, 2016

hansemannn commented Nov 16, 2016

m1ga commented Nov 16, 2016

jpriebe commented Jan 17, 2018

hansemannn commented Jan 17, 2018

m1ga commented Jan 17, 2018

jpriebe commented Jan 17, 2018 • edited

hansemannn May 5, 2016 •

edited

jpriebe commented Jan 17, 2018 •

edited