Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-6412] Android: rgba() fixes and addition for floats #7955

Merged
merged 2 commits into from Apr 22, 2016
Merged

[TIMOB-6412] Android: rgba() fixes and addition for floats #7955

merged 2 commits into from Apr 22, 2016

Conversation

m1ga
Copy link
Contributor

@m1ga m1ga commented Apr 20, 2016

JIRA: https://jira.appcelerator.org/browse/TIMOB-6412
JIRA: https://jira.appcelerator.org/browse/TIMOB-18821

Allows spaces between values and float values

working TSS values:

"#view1":{backgroundColor: "#f00"}
"#view2":{backgroundColor: "rgb(0,    255,    0)"}
"#view3":{backgroundColor: "rgba(0, 0 ,255, 128)"}
"#view4":{backgroundColor: "rgba(0,0 ,255 , 0.3 )"}
"#view5":{backgroundColor: "rgba(0,235,255,128)"}
"#view6":{backgroundColor: "rgba(0.4,0.4,0.4,0.4)"}

Image of Yaktocat

@sriks
Copy link
Contributor

sriks commented Apr 22, 2016

@m1ga Quick suggestion - from next time please mention ticket and title in commit message rather than cryptic. Ex:
[TIMOB-6412] Android: rgba() fixes and addition for floats

@sriks
Copy link
Contributor

sriks commented Apr 22, 2016

Code reviewed. FT Passed.

@sriks sriks merged commit e4a8d60 into tidev:master Apr 22, 2016
@m1ga m1ga deleted the rgba branch May 27, 2016 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants