TIMOB-6346 Android: allow imageview source to be nullified #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code reviewed. Request Accepted |
| @@ -248,17 +248,15 @@ public class TiUIImageView extends TiUIView implements OnLifecycleEvent, Handler | |||
|
|
|||
| private void setImage(final Bitmap bitmap) | |||
| { | |||
| if (bitmap != null) { | |||
There was a problem hiding this comment.
Do we need to worry about setting bitmap being null?
There was a problem hiding this comment.
eh? That's the point of this PR, and what we're testing :) In my testing, there are no adverse side-effects.
…de by putting in a handleXXX method. Also make sure default image is used (if available) when regular image source is null.
|
Code reviewed and functionally tested. Request Accepted |
|
Code reviewed and accepted. Merging |
rusticphilosopher
pushed a commit
that referenced
this pull request
Dec 1, 2011
TIMOB-6346 Android: allow imageview source to be nullified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://jira.appcelerator.org/browse/TIMOB-6346
Test case is the fail case in the ticket AND please test all ImageView tests in the KitchenSink.
I've also tested nullifying the image when the imageview is on a row in a TableView, and that also works fine. Not sure why we had the if-block in there in the first place.