[TIMOB-17450] TiAPI: Ti.Calendar.Event should expose the attendees of the meeting invite as a property #7981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of the meeting invite as a property.
|
Is this ready for review? |
|
@ashcoding Not yet. Im due to commit changes to iOS. |
|
Roger that. |
…of the meeting invite as a property - renamed type to role, added isOrganiser property.
…he meeting invite as a property.
…he meeting invite as a property - added docs.
…he meeting invite as a property - adding files to compilation
|
Thanks for the update! |
| } | ||
|
|
||
| public static ArrayList<AttendeeProxy> fetchAttendees(final long eventId, ContentResolver contentResolver) { | ||
| ArrayList<AttendeeProxy> attendees = new ArrayList<>(); |
There was a problem hiding this comment.
Looks like travis is failing here.
/Users/travis/build/appcelerator/titanium_mobile/android/modules/calendar/src/java/ti/modules/titanium/calendar/AttendeeProxy.java:53: error: diamond operator is not supported in -source 1.6 [javac] ArrayList<AttendeeProxy> attendees = new ArrayList<>(); [javac] ^ [javac] (use -source 7 or higher to enable diamond operator)
|
Will see if #8049 solves this. |
|
Just a note, can't compile it due to the usage of diamond operator, which is not supported. @hansemannn or @AngelkPetkov if the iOS is okay, you can probably cherry-pick them out as a separate PR. |
|
@ashcoding / @sgtcoolguy: Did you guys have a different PR that you opened for this for Android yet? Sorry, but I can't seem to find it if so. |
|
There's no different PR for this. This was rejected as it can't be compiled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-17450