[TIMOB-23327] iOS: Introducing onStopBlackListUrl #8019
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgtcoolguy
changed the title
AngelkPetkov
changed the title
| platforms: [iphone,iphone] | ||
| type: Boolean | ||
| default: false | ||
| since: "5.4.0" |
There was a problem hiding this comment.
As discussed, I don't like that properly. As it also causes parity problems, we should remove it and check every URL that is in the blacklist. If they want to exclude certain domains, they should remove them from the blacklist or set the blacklistedURLs after its creation, which should be possible.
| } | ||
|
|
||
|
|
||
| if ([self.proxy _hasListeners:@"beforeload"]) |
There was a problem hiding this comment.
Indentation is messed up through the whole new code-block.
[JIRA](https://jira.appcelerator.org/browse/TIMOB-23327?filter=-1) Do not merge/review!
AngelkPetkov
force-pushed
the
TIMOB-23327
branch
3 times, most recently
from
fcfd9de
to
78531bf
Compare
AngelkPetkov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA