[TIMOB-23452] iOS: Remove all deprecated API's with remove-version 6.0.0 #8028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and Ti.FIlesystem
and Ti.UI.iPhone.statusBarStyle
ATTRIBUTE_* from iOS-namespace
from UI-namespace, remove AttributedString from iOS-namespace
| the playing video will fill the entire video player area, obscuring any background | ||
| view. | ||
| platforms: [iphone, ipad] | ||
| parameters: |
There was a problem hiding this comment.
This is generating an error when you do node validate.js in apidoc
[ERROR] ./Titanium/Media/VideoPlayer.yml
Titanium.Media.VideoPlayer: found 1 error(s)!
properties
backgroundView
Invalid key: parameters
Most likely because it doesn't expect properties to contain parameters.
|
@hansemannn looks good. please fix conflicts and address comment. |
… TIMOB-23452 # Conflicts: # iphone/Classes/TiUIiOSProxy.m
|
Done, let's wait for the CI to finish. |
|
@hansemannn argh I'm sorry i forgot to merge. can you fix the conflicts.. again.. |
… TIMOB-23452 # Conflicts: # apidoc/Titanium/Media/Media.yml
|
Done |
|
APPROVED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-23452
Description:
This PR removes all API's that are marked to be removed in 6.0.0. It is structured to hold different proxy-changes in own commits to make it easier to review.