New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIMOB-23406] Android: add 'scrolling' event to listView #8031
Conversation
@@ -367,6 +368,23 @@ public void onScroll(AbsListView view, int firstVisibleItem, int visibleItemCoun | |||
{ | |||
_firstVisibleItem = firstVisibleItem; | |||
_visibleItemCount = visibleItemCount; | |||
|
|||
if (listView.getChildAt(0) != null){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can do View child = listView.getChildAt(0), so you dont have to call it twice
@m1ga Any movement on this? |
Can one of the admins verify this patch? |
@ashcoding I'll have a look at it again. There wasn't any feedback on my comment, thats why I didn't go any further with it :) But I'll have a look at it again and change the parts. I think there was a "bug" with checking the position of child(0) because it will jump from time to time (it looks like its removing the top item when its too far up). |
@m1ga Can you give me a timeframe in which you can take a look? I scheduled it for 6.1.0 now. |
@hansemannn Found a way to compile under linux again! So I can continue to work on it at the weekend! |
Closing this in favor of: #8216 |
JIRA: https://jira.appcelerator.org/browse/TIMOB-23406
Partiy PR