Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-23406] Android: add 'scrolling' event to listView #8031

Closed
wants to merge 3 commits into from
Closed

[TIMOB-23406] Android: add 'scrolling' event to listView #8031

wants to merge 3 commits into from

Conversation

m1ga
Copy link
Contributor

@m1ga m1ga commented May 28, 2016

@@ -367,6 +368,23 @@ public void onScroll(AbsListView view, int firstVisibleItem, int visibleItemCoun
{
_firstVisibleItem = firstVisibleItem;
_visibleItemCount = visibleItemCount;

if (listView.getChildAt(0) != null){
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can do View child = listView.getChildAt(0), so you dont have to call it twice

@ashcoding
Copy link
Contributor

@m1ga Any movement on this?
The first comment View child = listView.getChildAt(0) is pretty valid. As well as the second comment.

@build
Copy link
Contributor

build commented Jul 13, 2016

Can one of the admins verify this patch?

@m1ga
Copy link
Contributor Author

m1ga commented Jul 13, 2016

@ashcoding I'll have a look at it again. There wasn't any feedback on my comment, thats why I didn't go any further with it :) But I'll have a look at it again and change the parts. I think there was a "bug" with checking the position of child(0) because it will jump from time to time (it looks like its removing the top item when its too far up).

@hansemannn
Copy link
Collaborator

@m1ga Can you give me a timeframe in which you can take a look? I scheduled it for 6.1.0 now.

@hansemannn hansemannn added this to the 6.1.0 milestone Aug 7, 2016
@m1ga
Copy link
Contributor Author

m1ga commented Aug 8, 2016

@hansemannn Found a way to compile under linux again! So I can continue to work on it at the weekend!

@m1ga
Copy link
Contributor Author

m1ga commented Aug 13, 2016

Closing this in favor of: #8216

@m1ga m1ga closed this Aug 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants