[TIMOB-23459]: Null check in getFile() #8038
Conversation
| @@ -81,6 +81,10 @@ public boolean isExternalStoragePresent() | |||
| @Kroll.method | |||
| public FileProxy getFile(KrollInvocation invocation, Object[] parts) | |||
| { | |||
| //If directory doesn't exist, return | |||
| if (parts[0] == null) { | |||
There was a problem hiding this comment.
What if any of the parts are null? Does it cause an NPE or end up with a nonsense "null" string as a path segment?
There was a problem hiding this comment.
Just out of curiosity: Maybe Arrays.asList(parts).subList(0, parts.length).contains(null) or a manual loop?
There was a problem hiding this comment.
Also, I'd say we should log a warning or error to the user to let them know they passed in a null argument (maybe spit out the args received?) and we're returning null. Or throw a JS Error or something so they can pinpoint the bad call and know why they get back a null reference (or get the error thrown).
There was a problem hiding this comment.
If the file name is null, it won't make it to Java. I think the check should be sufficient
|
Functionally tested this. Crash does not occur any more. |
|
I'm going to merge and will have another PR to log out a warning. |
JIRA: https://jira.appcelerator.org/browse/TIMOB-23459