[TIMOB-23310] Update v8 engine to 5.0.71.33

.travis.yml

@@ -4,7 +4,7 @@ jdk:
   - oraclejdk7
 install:
   - ANDROID_SDK_PACKAGE=android-sdk_r24.0.1-macosx.zip
-  - ANDROID_NDK_PACKAGE=android-ndk-r10e-darwin-x86_64.zip
+  - ANDROID_NDK_PACKAGE=android-ndk-r11c-darwin-x86_64.zip
   - export TITANIUM_ANDROID_API="23"
   - export SDKS="$TRAVIS_BUILD_DIR/sdks"
   - echo $SDKS
@@ -23,8 +23,8 @@ install:
   - echo yes | android -s update sdk --no-ui --all --filter sys-img-armeabi-v7a-android-22
 
   - # Install required Android NDK
-  - if [ ! -d "$SDKS/android-ndk-r10e" ]; then wget http://dl.google.com/android/repository/$ANDROID_NDK_PACKAGE; unzip -q -o $ANDROID_NDK_PACKAGE; fi
-  - export ANDROID_NDK=${PWD}/android-ndk-r10e
+  - if [ ! -d "$SDKS/android-ndk-r11c" ]; then wget http://dl.google.com/android/repository/$ANDROID_NDK_PACKAGE; unzip -q -o $ANDROID_NDK_PACKAGE; fi
+  - export ANDROID_NDK=${PWD}/android-ndk-r11c
   -
   - export ANDROID_PLATFORM=$ANDROID_SDK/platforms/android-$TITANIUM_ANDROID_API
   - export GOOGLE_APIS=$ANDROID_SDK/add-ons/addon-google_apis-google-$TITANIUM_ANDROID_API

android/build/libv8.properties

@@ -1,2 +1,2 @@
-libv8.version=3.9.24.29
+libv8.version=5.0.71.33
 libv8.mode=release

android/cli/commands/_build.js

@@ -69,7 +69,7 @@ function AndroidBuilder() {
 
 	this.targets = ['emulator', 'device', 'dist-playstore'];
 
-	this.validABIs = ['armeabi', 'armeabi-v7a', 'x86'];
+	this.validABIs = ['armeabi-v7a', 'x86'];
 
 	this.xmlMergeRegExp = /^(strings|attrs|styles|bools|colors|dimens|ids|integers|arrays)\.xml$/;
 

android/cli/commands/_buildModule.js

@@ -1076,7 +1076,7 @@ AndroidModuleBuilder.prototype.ndkBuild = function (next) {
 						}
 
 						this.dirWalker(this.buildGenLibsDir, function (file) {
-							if (path.extname(file) == '.so' && file.indexOf('libstlport_shared.so') == -1) {
+							if (path.extname(file) == '.so' && file.indexOf('libstlport_shared.so') == -1 && file.indexOf('libc++_shared.so') == -1) {
 
 								var relativeName = path.relative(this.buildGenLibsDir, file),
 									targetDir = path.join(this.libsDir, path.dirname(relativeName));

android/kroll-apt/src/java/org/appcelerator/kroll/annotations/generator/ProxyBinding.fm

@@ -169,29 +169,29 @@
 
 <#macro openModuleNamespace>
 	<#list moduleId?split(".") as ns>
-		namespace ${ns?lower_case} {
+namespace ${ns?lower_case} {
 	</#list>
 </#macro>
 
 <#macro closeModuleNamespace>
 	<#list moduleId?split(".")?reverse as ns>
-		} // ${ns?lower_case}
+} // ${ns?lower_case}
 	</#list>
 </#macro>
 
 <#macro openNamespace>
 <@openModuleNamespace/>
 	<#list proxyAttrs.fullAPIName?split(".") as ns>
 		<#if ns_has_next && ns?lower_case != moduleId?lower_case>
-			namespace ${ns?lower_case} {
+	namespace ${ns?lower_case} {
 		</#if>
 	</#list>
 </#macro>
 
 <#macro closeNamespace>
 	<#list proxyAttrs.fullAPIName?split(".")?reverse as ns>
 		<#if ns_index != 0 && ns?lower_case != moduleId?lower_case>
-			} // namespace ${ns?lower_case}
+	} // namespace ${ns?lower_case}
 		</#if>
 	</#list>
 <@closeModuleNamespace/>
@@ -426,7 +426,7 @@
 	<#if type?ends_with("Proxy")>
 		<#return typeInfo["org.appcelerator.kroll.KrollProxy"]>
 	</#if>
-	
+
 	<#if type?ends_with("Exception")>
 		<#return typeInfo["org.appcelerator.kroll.KrollException"]>
 	</#if>
@@ -485,7 +485,8 @@ fails, a JS exception is returned.
 		const char *error = "Invalid value, expected type ${info.jsType}.";
 		LOGE(TAG, error);
 		<#if !(logOnly!false)>
-		return titanium::JSException::Error(error);
+		titanium::JSException::Error(isolate, error);
+		return;
 		</#if>
 	}
 	</#if>
@@ -510,31 +511,37 @@ fails, a JS exception is returned.
 		<#local valueExpr = expr>
 	<#elseif info.jsType == "Number">
 		<#local type = "Local<Number>">
-		<#local valueExpr = expr + "->ToNumber()">
-		<#local stringExpr = expr + "->ToString()">
+		<#local valueExpr = expr + "->ToNumber(isolate)">
+		<#local stringExpr = expr + "->ToString(isolate)">
 	<#elseif info?keys?seq_contains("jsHandleCast")>
 		<#local type = "Local<" + info.jsType + ">">
-		<#local valueExpr = "Local<" + info.jsType + ">::Cast(" + expr + ")">
+		<#local valueExpr = expr + ".As<" + info.jsType + ">()">
 	<#else>
 		<#local type = "Local<" + info.jsType + ">">
-		<#local valueExpr = expr + "->To" + info.jsType + "()">
+		<#local valueExpr = expr + "->To" + info.jsType + "(isolate)">
 	</#if>
-	
+
 <#t>
 	<#if info.jsType == "Number">
-		if ((titanium::V8Util::isNaN(${expr}) && !${expr}->IsUndefined()) || ${stringExpr}->Length() == 0) {
+		if ((titanium::V8Util::isNaN(isolate, ${expr}) && !${expr}->IsUndefined()) || ${stringExpr}->Length() == 0) {
 			const char *error = "Invalid value, expected type ${info.jsType}.";
 			LOGE(TAG, error);
 			<#if !(logOnly!false)>
-			return titanium::JSException::Error(error);
+			titanium::JSException::Error(isolate, error);
+			return;
 			</#if>
 		}
 	</#if>
 <#t>
 	if (!${expr}->IsNull()) {
 		${type} ${current_arg} = ${valueExpr};
 		jArguments[${index}].${info.jvalue} =
-			titanium::TypeConverter::${info.jsToJavaConverter}(env, ${current_arg}<#if checkNew>, &isNew_${index}</#if>);
+			titanium::TypeConverter::${info.jsToJavaConverter}(
+		<#if info.jsToJavaConverter?matches("^js(Number|Date|String|Boolean)To.+")>
+		<#else>
+				isolate,
+		</#if>
+				env, ${current_arg}<#if checkNew>, &isNew_${index}</#if>);
 	} else {
 		jArguments[${index}].${info.jvalue} = NULL;
 	}
@@ -553,7 +560,7 @@ fails, a JS exception is returned.
 	jobjectArray varArgs = env->NewObjectArray(length, titanium::JNIUtil::objectClass, NULL);
 	for (uint32_t i = 0; i < length; ++i) {
 		bool isNew;
-		jobject arg = titanium::TypeConverter::jsValueToJavaObject(env, args[i+${start}], &isNew);
+		jobject arg = titanium::TypeConverter::jsValueToJavaObject(isolate, env, args[i+${start}], &isNew);
 		env->SetObjectArrayElement(varArgs, i, arg);
 		if (isNew) {
 			env->DeleteLocalRef(arg);
@@ -570,7 +577,8 @@ fails, a JS exception is returned.
 	if (args.Length() < ${requiredCount}) {
 		char errorStringBuffer[100];
 		sprintf(errorStringBuffer, "${method.apiName}: Invalid number of arguments. Expected ${requiredCount} but got %d", args.Length());
-		return ThrowException(Exception::Error(String::New(errorStringBuffer)));
+		titanium::JSException::Error(isolate, errorStringBuffer);
+		return;
 	}
 	</#if>
 	</@Proxy.getRequiredArgumentCount>
@@ -586,9 +594,9 @@ fails, a JS exception is returned.
 	</#list>
 
 	<#if method.hasInvocation>
-	Handle<Object> scopeVars = args[0]->ToObject();
-	jstring sourceUrl = titanium::TypeConverter::jsValueToJavaString(env, 
-		scopeVars->Get(Proxy::sourceUrlSymbol));
+	Local<Object> scopeVars = args[0]->ToObject(isolate);
+	jstring sourceUrl = titanium::TypeConverter::jsValueToJavaString(isolate, env,
+		scopeVars->Get(Proxy::sourceUrlSymbol.Get(isolate)));
 	jArguments[0].l = env->NewObject(titanium::JNIUtil::krollInvocationClass,
 		titanium::JNIUtil::krollInvocationInitMethod, sourceUrl);
 	env->DeleteLocalRef(sourceUrl);
@@ -666,21 +674,22 @@ beprovided to handle the result.
 	<@Proxy.cleanupMethodArguments args=methodArgs hasInvocation=hasInvocation/>
 
 	if (env->ExceptionCheck()) {
-		<#if hasResult>Handle<Value> jsException = </#if>titanium::JSException::fromJavaException();
+		<#if hasResult>Local<Value> jsException = </#if>titanium::JSException::fromJavaException(isolate);
 		env->ExceptionClear();
 		<#if hasResult>
-		return jsException;
+		return;
 		</#if>
 	}
 
 	<#if hasResult && info.javaValidation!false>
 	if (jResult == NULL) {
-		return Null();
+		args.GetReturnValue().Set(Null(isolate));
+		return;
 	}
 	</#if>
 
 	<#if hasResult>
-	Handle<${jsType}> v8Result = titanium::TypeConverter::${info.javaToJsConverter}(env, jResult);
+	Local<${jsType}> v8Result = titanium::TypeConverter::${info.javaToJsConverter}(isolate, env, jResult);
 
 	<#if info.javaDeleteLocalRef!false>
 	env->DeleteLocalRef(jResult);
@@ -693,7 +702,8 @@ beprovided to handle the result.
 <#macro initJNIEnv>
 	JNIEnv *env = titanium::JNIScope::getEnv();
 	if (!env) {
-		return titanium::JSException::GetJNIEnvironmentError();
+		titanium::JSException::GetJNIEnvironmentError(isolate);
+		return;
 	}
 </#macro>
 
@@ -706,7 +716,8 @@ beprovided to handle the result.
 			const char *error = "Couldn't find proxy method '${name}' with signature '${signature}'";
 			LOGE(TAG, error);
 			<#if !(logOnly!false)>
-				return titanium::JSException::Error(error);
+				titanium::JSException::Error(isolate, error);
+				return;
 			</#if>
 		}
 	}