Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-15483] Update Window.yml: use transparent image for barImage #8052

Merged
merged 2 commits into from Jun 13, 2016
Merged

[TIMOB-15483] Update Window.yml: use transparent image for barImage #8052

merged 2 commits into from Jun 13, 2016

Conversation

m1ga
Copy link
Contributor

@m1ga m1ga commented Jun 11, 2016

Useful tip from https://jira.appcelerator.org/browse/TIMOB-15483?focusedCommentId=375222&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-375222 to set the navigationbar to a solid color AND removing the shadow without creating a image for every color
@@ -365,6 +365,7 @@ properties:
The behavior of this API on iOS has changed from version 3.2.0. Previous versions
of the SDK created a custom image view and inserted it as a child of the navigation bar.
The titanium sdk now uses the native call to set the background image of the navigation bar.
You can set it to a 1px transparent png to use a combination of barColor and hideShadow:true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing punctuation point. Also please use code-highlighting for barColor and hideShadow: true.

@hansemannn
Copy link
Collaborator

Approved!

@hansemannn hansemannn merged commit 07f24ac into tidev:master Jun 13, 2016
@m1ga m1ga deleted the patch-1 branch June 28, 2016 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants