[TIMOB-23501] iOS: Label.ellipsize should not return undefined

[AngelkPetkov]

JIRA

[hansemannn]

Cannot remove the old implementation, we need to throw at least a deprecation warning for boolean inputs.

[m1ga]

I've added the android part and set the default value to false because you can turn it off that way (and its off when you just create a label). So the return value is a boolean in my case. Is there a way to turn it off on iOS, too?

[hansemannn]

Instead of this, please check if the input is a bool and leave the if-block as it is, if so.

[hansemannn]

@AngelkPetkov please cherry-pick his Android-changes into this PR and I will FT it.

[AngelkPetkov]

Updated Boolean check and added #8094.

Thank you @m1ga !

[hansemannn]

There is an issue here @AngelkPetkov @m1ga:

var label = Ti.UI.createLabel();

Ti.API.warn(label.getEllipsize()); // Should be "4" (Integer for Ti.UI.TEXT_ELLIPSIZE_TRUNCATE_END - default)
Ti.API.warn(label.getEllipsize() == Ti.UI.TEXT_ELLIPSIZE_TRUNCATE_END); // Should be "true"
Ti.API.warn(label.getEllipsize() == Ti.UI.TEXT_ELLIPSIZE_TRUNCATE_MIDDLE); // Should be "false"

label.setEllipsize(Ti.UI.TEXT_ELLIPSIZE_TRUNCATE_MIDDLE);

Ti.API.warn(label.getEllipsize()); // Should be "5" (Integer for Ti.UI.TEXT_ELLIPSIZE_TRUNCATE_MIDDLE)
Ti.API.warn(label.getEllipsize() == Ti.UI.TEXT_ELLIPSIZE_TRUNCATE_MIDDLE); // Should be "true"
Ti.API.warn(label.getEllipsize() == Ti.UI.TEXT_ELLIPSIZE_TRUNCATE_END); // Should be "false"

As the constants only represent a name for a number, the above logs output numbers. On iOS, it is 4 and 5, on Android it is 2 and 1. I think, as long as the user checks agains the constants and not against the numbers, it's fine. We cannot ensure that all constants across all platforms represent the same number, so this is the way to go. Do you guys agree?

[hansemannn]

• doesnt -> doesn't
• Missing period at the end of the sentence

[AngelkPetkov]

Yeah i had it as doesn't originally however node validate doesn't like ' as its a non ASCII character, so i removed it

[hansemannn]

Use the correct sign there as we do in related docs. Search UI.yml for other usages and copy it from there.

[hansemannn]

FT passed, please address the documentation comments before merging.

[hansemannn]

CR + FT passed, PR approved.