[TIMOB-23500] Android: default value for ellipsize #8094
Conversation
|
Can one of the admins verify this patch? |
|
Hello, thank you for the contribution! However the value for the ellipsize should not actually be a boolean, but it should return the constant. An Android fix is in progress #8086 for parity reasons. |
|
I've added a comment in your PR :) Sorry for crossposting |
|
FT Approved! |
| @@ -135,6 +135,7 @@ public boolean onTouchEvent(MotionEvent event) { | |||
| tv.setKeyListener(null); | |||
| tv.setFocusable(false); | |||
| tv.setSingleLine(false); | |||
| tv.setEllipsize(ellipsize); | |||
There was a problem hiding this comment.
How does that effect current labels that do not have any ellipsize property defined? We should try to ensure that nothing breaks after this change (although 6.0 would be the right time to do this).
There was a problem hiding this comment.
I think it will just be a "good" change:
it will just affect the fields where you have a fixed width (no wordWrap) and the text would be out of the label anyway. That's mostly the point where you are searching on how to switch on ellipsize :)
But since Android can switch of the ellipsizing it might have a different default value. I would prefer truncateAt.END because it will make the label look the same on both platforms from the beginning. You decide ;)
There was a problem hiding this comment.
Like it, thanks for that great example!
JIRA: https://jira.appcelerator.org/browse/TIMOB-23500