Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-23572] iOS/Android: Expose Ti.App.Properties.removeAllProperties() #8096

Merged
merged 2 commits into from Jul 21, 2016

Conversation

hansemannn
Copy link
Collaborator

@FokkeZB
Copy link
Contributor

FokkeZB commented Jun 29, 2016

You 🎸!

@hansemannn hansemannn changed the title [TIMOB-23572] Remove all Ti.App.Properties at once [TIMOB-23572] iOS/Android: Remove all Ti.App.Properties at once Jul 1, 2016
@hansemannn hansemannn changed the title [TIMOB-23572] iOS/Android: Remove all Ti.App.Properties at once [TIMOB-23572] iOS/Android: Expose Ti.App.Properties.removeAllProperties() Jul 2, 2016
@AngelkPetkov
Copy link
Contributor

FT on IOS looks good, however cannot compile on android when using scons :

[javac] import org.appcelerator.titanium.TiContext;
    [javac]                                 ^
    [javac]   symbol:   class TiContext
[javac]   location: package org.appcelerator.titanium
[javac] /Users/apetkov/Documents/titanium_mobile/android/modules/app/src/java/ti/modules/titanium/app/properties/PropertiesModule.java:30: error: cannot find symbol
[javac]     public PropertiesModule(TiContext tiContext)
    [javac]                             ^
[javac]   symbol:   class TiContext
    [javac]   location: class PropertiesModule
[javac] 2 errors

@hansemannn
Copy link
Collaborator Author

hansemannn commented Jul 12, 2016

I guess it's because of the V8-updates @sgtcoolguy did recently where he removed those constructors. I pulled from master and the constructor gone (as it's supposed to be), please try again.

@AngelkPetkov
Copy link
Contributor

Prettty sure you just merged all the changes into master

@hansemannn
Copy link
Collaborator Author

No I didn't. I merged master into the branch.

@AngelkPetkov
Copy link
Contributor

Are you sure because i just created a fresh branch pulled from mater and all your changes are there

@hansemannn
Copy link
Collaborator Author

Yes, very sure. The last commits have been from you merging my other PR's. You probably mixed up your local fork.

@AngelkPetkov
Copy link
Contributor

Approved!

@AngelkPetkov AngelkPetkov merged commit 8935f80 into tidev:master Jul 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants