[TIMOB-19335] iOS: Add identifier to Ti.UI.ListView rowAction #8097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1036,6 +1037,9 @@ -(NSArray*)editActionsFromValue:(id)value | |||
| if (itemId != nil) { | |||
| [eventObject setObject:itemId forKey:@"itemId"]; | |||
| } | |||
| if (identifier) { | |||
There was a problem hiding this comment.
Change to != nill to match the above coding style
|
FT and CR approved! |
|
Please use the demo-code provided in the ticket, since this one does not check for the changes being made in the ticket. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-19335