[TIMOB-23584] iOS9: Add support for added textStyles (Title1,Title2, Title2, Callout) #8100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…extStyle3, UIFontTextStyleCallout on devices running iOS9 or higher. On other devices, these 4 are changed to UIFontTextStyleBody and it is the developer's responsibilty to adjust their code accordingly
|
Can one of the admins verify this patch? |
stephenfeather
changed the title
|
ok to test |
|
Hey @stephenfeather, PR looks great! Please add the docs with `since: "6.0.0"`` and I can go ahead to merge. Thanks! 🚀 |
|
PR approved, good work @stephenfeather! 🤘🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-23584
Optional Description:
Add support for UIFontTextStyleTitle1, UIFontTextStyleTitle2, UIFontTextStyle3, UIFontTextStyleCallout on devices running iOS9 or higher. On other devices, these 4 are changed to UIFontTextStyleBody and it is the developer's responsibilty to adjust their code accordingly
Thanks to @Core-13 (Malcolm Hollingsworth) for testing backward compatiblity on devices that still have iOS 8.x on them