[TIMOB-23612] Android: Improve requestPerm docs #8109
Conversation
This PR is to improve the documentation of Ti.Android.requestPermissions() documentation.
| @@ -93,6 +93,36 @@ description: | | |||
| For more information about services, see the | |||
| [Titanium.Android.Service API reference](Titanium.Android.Service). | |||
|
|
|||
| #### Permissions | |||
|
|
|||
| Starting from Android 6.0 (API level 23), users need to grant permissions to apps while the | |||
There was a problem hiding this comment.
Not all permissions need to be granted while the app is running, right?
|
Left two 2 minor comments for improved readability. Should we link to this section from the API's that require these permissions (e.g. Ti.Contacts) or do people know about this section? I would personally not think about primary searching there, but in the description of the related API's. |
|
That's a good point. I'll leave additional notes in those section (eg Ti.Contacts, Ti.Geolocation) mentioning about this general permission API. What do you think? |
|
That would be awesome! So we have everything linked with each other and people don't get confused. Think of the API's that might need the note and we're good to go. Thanks man! 🚀 |
|
Comments addressed. |
|
Love it! Approved 🚀 |
JIRA: https://jira.appcelerator.org/browse/TIMOB-23612
Android: Improve
Ti.Android.requestPermissions()documentationOptional Description:
This PR is to improve the documentation of
Ti.Android.requestPermissions() documentation.