[TIMOB-16218] Fix Ti.UI.RefreshControl.beginRefreshing, refactor proxy and docs #8115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… TIMOB-16218 # Conflicts: # iphone/Classes/TiUIRefreshControlProxy.m
| summary: This is false. This event does not bubble | ||
| type: Boolean | ||
| - name: refreshend | ||
| summary: Fired in response to a user finished an action to refresh the contents of the table view, list view or scroll view. |
There was a problem hiding this comment.
This sentence doesn't make sense,reword please.
There was a problem hiding this comment.
It is the native description Apple provides and is copied & adjusted from refreshstart.
There was a problem hiding this comment.
Link it please, but regardless its not grammatically correct. It should be "initiated action" or "user initiating an action" (which i know doesn't apply here as the action is already initiated).
|
FT and CR approved, address the comment above please and will merge 👍 |
|
Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-16218