Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-16985] Android: Removed Ti.UI.Window.url #8161

Merged
merged 1 commit into from Jul 28, 2016
Merged

[TIMOB-16985] Android: Removed Ti.UI.Window.url #8161

merged 1 commit into from Jul 28, 2016

Conversation

ashcoding
Copy link
Contributor

@ashcoding
Copy link
Contributor Author

I believe this is the only part for the url property to be removed.

@ashcoding ashcoding added this to the 6.0.0 milestone Jul 27, 2016
@hansemannn
Copy link
Collaborator

Will wait for the log-warning to be added as discussed.

@ashcoding
Copy link
Contributor Author

I do not see the usage of TiC.PROPERTY_URL which is the string "url" for the WindowProxy in Android. For it to have a log-warning, the property still needs to be in. Since it's not in use, I think removing it is fine.

With the documentation for 6.0.0 and all the information informing people about breaking changes, I think this should suffice.

@hansemannn
Copy link
Collaborator

Alrighty! Approved!

@hansemannn hansemannn merged commit 5f379d9 into tidev:master Jul 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hansemannn hansemannn

Labels
android BREAKING CHANGES ⚠️
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ashcoding @hansemannn