Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-23649] Bug fix for generated manifest.json #8190

Merged
merged 1 commit into from Aug 4, 2016

Conversation

ashcoding
Copy link
Contributor

https://jira.appcelerator.org/browse/TIMOB-23649

Bug fix for the generated manifest.json.

@ashcoding
Copy link
Contributor Author

ashcoding commented Aug 4, 2016

To test, run scons to build, package and install.
Check the manifest.json file in the installed sdk.
If it shows:

{
  "name": "6.0.0",
  "version": "6.0.0",
  "moduleAPIVersion": {
    "iphone": "2",
    "android": "3",
    "mobileweb": "2",
    "windows": "2"
  },
  "timestamp": "8/4/2016 05:25",
  "githash": "c5cb644",
  "platforms": [
    "android",
    "iphone",
    "mobileweb"
  ]
}

This is correct.

The original incorrect manifest.json was:

{
  "name": "6.0.0",
  "version": "6.0.0",
  "moduleAPIVersion": "[object Object]",
  "timestamp": "8/4/2016 05:17",
  "githash": "6f132a1",
  "platforms": [
    "android",
    "iphone",
    "mobileweb"
  ]
}

This prevented Studio from adding Api Version 3 modules for android.

@ashcoding
Copy link
Contributor Author

ashcoding commented Aug 4, 2016

An additional test you can do is, in Studio, use the SDK and try to add a API Version 3 module https://github.com/appcelerator-modules/ti.imagefactory/releases/tag/android-3.0.0

If it appears and selectable, it's working.

@ashcoding
Copy link
Contributor Author

For my own ref: http://www.ecma-international.org/ecma-262/5.1/#sec-15.2.4.2
Reason behind why toString() is wrong.

@sgtcoolguy
Copy link
Contributor

Checked the generated SDK zip's manifest.json and it looks good. Merging.

@sgtcoolguy sgtcoolguy merged commit a0a008d into tidev:master Aug 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants