[TIMOB-23745] Android: Crash using Math.random #8196
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-23745
Description:
Calling Math.random() in JS code, like so:
Would crash against Titanium SDK 6.0+ on Android.
The culprit was a local reference/instantiation of a V8 ArrayBufferAllocator. I needed to move the definition of the allocator up into the global scope so it wouldn't get GC'd in C++ when the V8Runtime.nativeInit finished.