Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-23767] Fix tint-color to gray, update label #8235

Merged
merged 1 commit into from Aug 16, 2016

Conversation

hansemannn
Copy link
Collaborator

@ashcoding
Copy link
Contributor

Approved

@ashcoding
Copy link
Contributor

ashcoding commented Aug 16, 2016

The PR for this fix is fine.
Travis Failed due to another separate issue.
https://travis-ci.org/appcelerator/titanium_mobile/builds/152615412#L4874-L4903

Zipping Mobile SDK...
Cleaning previous zipfile and tmp dir...
Writing manifest.json
Zipping packaged modules...
Unzipping /Users/travis/build/appcelerator/titanium_mobile/support/module/packaged/com.appcelerator.urlSession-iphone-2.0.0.zip to /Users/travis/build/appcelerator/titanium_mobile/dist/ziptmp
Unzipping /Users/travis/build/appcelerator/titanium_mobile/support/module/packaged/facebook-android-6.0.1.zip to /Users/travis/build/appcelerator/titanium_mobile/dist/ziptmp
Unzipping /Users/travis/build/appcelerator/titanium_mobile/support/module/packaged/facebook-iphone-5.2.3.zip to /Users/travis/build/appcelerator/titanium_mobile/dist/ziptmp
{ Error: Command failed: unzip -o "/Users/travis/build/appcelerator/titanium_mobile/support/module/packaged/facebook-iphone-5.2.3.zip" -d "/Users/travis/build/appcelerator/titanium_mobile/dist/ziptmp"
  End-of-central-directory signature not found.  Either this file is not
  a zipfile, or it constitutes one disk of a multi-part archive.  In the
  latter case the central directory and zipfile comment will be found on
  the last disk(s) of this archive.
unzip:  cannot find zipfile directory in one of /Users/travis/build/appcelerator/titanium_mobile/support/module/packaged/facebook-iphone-5.2.3.zip or
        /Users/travis/build/appcelerator/titanium_mobile/support/module/packaged/facebook-iphone-5.2.3.zip.zip, and cannot find /Users/travis/build/appcelerator/titanium_mobile/support/module/packaged/facebook-iphone-5.2.3.zip.ZIP, period.
    at ChildProcess.exithandler (child_process.js:202:12)
    at emitTwo (events.js:106:13)
    at ChildProcess.emit (events.js:191:7)
    at maybeClose (internal/child_process.js:850:16)
    at Socket.<anonymous> (internal/child_process.js:323:11)
    at emitOne (events.js:96:13)
    at Socket.emit (events.js:188:7)
    at Pipe._handle.close [as _onclose] (net.js:485:12)
  killed: false,
  code: 9,
  signal: null,

Will merge this but this other issue needs to be looked into.
CC: @cheekiatng , @hansemannn

@ashcoding ashcoding merged commit e5895e2 into tidev:master Aug 16, 2016
@ashcoding
Copy link
Contributor

This error seems to be only in master branch after it has been bumped to 6.1.0.

@ashcoding
Copy link
Contributor

@hansemannn did this 92f288d cause the issue?

@hansemannn
Copy link
Collaborator Author

Fix is uploading, the old binary I uploaded today morning seems to be corrupt during push (during Standup). Will merge and fix in the next 10m.

@hansemannn
Copy link
Collaborator Author

hansemannn commented Aug 16, 2016

Merged in #8237.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants