(5.5.X)Fix wrong ifdef statmenet #8259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs approval from @eric34 and @cheekiatng beforehand. It basically fixes an issue where the ProgressBarStyle constants could not found unless you define an AnimationStyle constant. @AngelkPetkov please also file a ticket for that asap and link it here. |
|
Will file a ticket, but the main issue is that it will cause a crash as well, if you use animationStyle. As it would define the progressBar in the iOSProxy.m file but the actual file will not be defined and will crash with null pointer. Ticket: JIRA |
|
we want this in 5.5.0. I see the JIRA ticket is up. @hansemannn merge please. |
|
Approved! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA