TIMOB-6191 Android: Re-enable services for both runtimes #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…titanium-android to the point of no warnings anymore in Eclipse.
| fullUrl = fullUrl.replaceAll("file:///android_asset/", ""); | ||
| } | ||
|
|
||
| proxy.fireEvent("resume", new KrollDict()); |
There was a problem hiding this comment.
These lifecycle events should already be TiC constants (IIRC we already use these for activities)
|
Functional testing passed. WIll run again once CR accepted. |
|
Code reviewed and functional test passed on both V8 and Rhino. Accepted |
|
Code review passed, request accepted |
marshall
added a commit
that referenced
this pull request
Dec 5, 2011
TIMOB-6191 Android: Re-enable services for both runtimes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://jira.appcelerator.org/browse/TIMOB-6191
Test case is the KitchenSink Platform - Android Services tests.