Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-23890] iOS: Post notification in openURL-delegate, use newer delegate for iOS9+ #8346

Merged
merged 5 commits into from Sep 12, 2016

Conversation

hansemannn
Copy link
Collaborator

@hansemannn hansemannn changed the title [TIMOB-23890] iOS: Post notification in openURL [TIMOB-23890] iOS: Post notification in openURL-delegate, use newer delegate for iOS9+ Sep 12, 2016
@@ -1124,6 +1124,18 @@ events:
osver: {ios: {min: "9.0"}}
since: '5.1.0'

- name: handleurl
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cheekiatng In case you ask why we need this here: It is triggered by https://jira.appcelerator.org/browse/TIMOB-23884 that is caused by an open Apple issue. It is both workaround until Apple fixes it as well as the future-way to receive updates from URL's that get handled by the application.

And since it used the same notification as below (kTiApplicationLaunchedFromURL), it can be used here as well.

@cheekiatng
Copy link
Contributor

CR AND FT PASSED. APPROVED!

@cheekiatng cheekiatng merged commit d1d1cf7 into tidev:master Sep 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants