[TIMOB-23924] Move internal focus-call to selector #8408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
APPROVED! |
|
This can be reverted; it seems that this has been fixed inside Apple. We faced the same problem and also opened up a rdar about it: https://pspdfkit.com/guides/ios/current/announcements/private-api-rejections/ The last report we got about this was at the end of September. Seems fixed. |
|
We also didn't receive any new reports since then. @cheekiatng we can remove it for master again, but let's wait a few more weeks for Apple to confirm this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-23924
Temporary solution until Apple fixes their private API-detection, since
focus:is no private selector but our ownTiKeyboardFocusableViewdelegate.