[TIMOB-23901] Fix IdleNotificationDeadline() duration

[garymathews]

• This is the root cause of the splash screen issue, the nativeDispose() call hangs the KrollRuntimeThread which prevents the message handler from processing the MSG_INIT to re-initialise KrollRuntime
• This is due to an incorrect IdleNotificationDeadline() duration

TEST CASE

1. Create and launch any Titanium Android application
2. Press the back button to close the app
3. Launch the app again

EXPECTED

• Application should resume

ACTUAL

• Application hangs on splash screen

JIRA Ticket

[build]

Can one of the admins verify this patch?

[sgtcoolguy]

ok to test

[sgtcoolguy]

add to whitelist

[sgtcoolguy]

looks good to me.

[sgtcoolguy]

@garymathews If this one is wrong, is this one too? https://github.com/garymathews/titanium_mobile/blob/aded055ba50c95732f1c19711243ff22c65b0431/android/runtime/v8/src/native/V8Runtime.cpp#L322

[sgtcoolguy]

@ashcoding @garymathews I guess maybe the old V8 integration had effectively the same bug?

It seemed unlikely, but maybe it's not?

These seem relevant:

• https://github.com/lloyd/node-memwatch/pull/60/files#diff-69f2d078b3741241d21a4c6dc64b61cfR245
• http://stackoverflow.com/questions/18701003/v8idlenotification-never-returns-true

They moved from:

while(!V8::IdleNotification()) {};

to:

while(!V8::IdleNotification(500)) {};
V8::LowMemoryNotification();

Though, I honestly don't think there's much difference there. The first is actually equivalent to:

while(!V8::IdleNotification(1000)) {};

I mean that code could possibly just loop forever and not return true - but I don't really know.

[ashcoding]

@garymathews Tested this PR by building master branch and using Nexus 6 with Android 6.0 running. Still facing the issue. I'll add comments on the JIRA ticket to ask for QE to help test this.