[TIMOB-23960] iOS: Fix unrecognized selector crash when using background-notifications #8437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! But we need a JIRA-ticket + reproducible test-case in order to integrate the PR. Can you file one? Then I will take care of it, thanks! EDIT: Added ticket and test-case. |
hansemannn
changed the title
|
Approved! |
|
@hansemannn Thanks. I requested a Jira account. Do you still need a ticket + test case? |
|
@rlepinski all done 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-23960
If you enable background notifications in iOS it crashes the application when a push is received. It looks like TiApp never implements the method that its forwarding on, so I am guessing its relying on a module to swizzle that method into place.
Discovered this when updating the UA module. We dropped that method because its been deprecated in iOS 8 and we now require background fetch.