[TIMOB-23925] iOS: Wrap platform-API's in precompile-macros #8456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… TIMOB-23925 # Conflicts: # iphone/Classes/MediaModule.m
cheekiatng
suggested changes
Oct 3, 2016
| @@ -205,7 +214,8 @@ -(NSString*)apiName | |||
| MAKE_SYSTEM_PROP_DEPRECATED_REPLACED_REMOVED(audioLineType,-10,@"Media.audioLineType",@"3.4.2",@"3.6.0",@"Media.currentRoute"); | |||
|
|
|||
| //Constants for currentRoute | |||
| MAKE_SYSTEM_STR(AUDIO_SESSION_PORT_LINEIN,AVAudioSessionPortLineIn) | |||
| #ifdef USE_TI_MEDIAAUDIOPLAYER | |||
| MAKE_SYSTEM_STR(text,AVAudioSessionPortLineIn) | |||
There was a problem hiding this comment.
I maybe wrong, but this can't be text right?
There was a problem hiding this comment.
Good catch! Addressed.
cheekiatng
suggested changes
Oct 3, 2016
|
|
||
| #import "TiMediaAudioPlayerProxy.h" | ||
| #import "TiUtils.h" | ||
| #ifdef USE_TI_MEDIAAUDIOSESSION |
There was a problem hiding this comment.
Using KitchenSink, the build fails because of this. Apparently, USE_TI_MEDIAAUDIOSESSION will not be generated in defines.h when building to device. commenting this out makes it build normally.
| #define USE_TI_MEDIAISMEDIATYPESUPPORTED | ||
| #define USE_TI_MEDIASAVETOGALLERY | ||
| #define USE_TI_MEDIASTARTVIDEOEDITING | ||
| #define USE_TI_MEDIAAUDIOSESSION |
There was a problem hiding this comment.
Based on testing on device using KitchenSInk, This define is not necessary since it doesn't get generated when building to device, even when the app manages audio player.
|
KitchenSink builds and Media-related code runs fine after these issues were addressed. |
|
CR and FT passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-23925