Timob 6017 Mobile web animation. #847
Conversation
…the basics of animation.
… supported in mobileweb), autoreverse, and repeat.
…'t (and couldn't) work properly and replaced it with a separate rotation entry in animations.
…le into mobileweb
…the args passed in.
…e and 0 were invalid.
…ton (this isn't a form afterall).
…. It was ignoring all passed-in parameters. Created an alternate method to avoid potentially breaking things.
…t anything in the constructor, not just the official API properties of the object.
…le into mobileweb
…e into timob-6017
…e into timob-6017
…e into timob-6017
…emoved some edge-case detection that was too brittle.
| duration = val[prop] | ||
| } else { | ||
| props.push(prop); | ||
| obj._setPrefixedCSSRule = function(rule,value) { |
There was a problem hiding this comment.
This is AWESOME! My only concern is eventually rules like "transition" will no longer require a vendor prefix and the rule should be "transition" and not "Transition". In other words, you should auto-capitalize the rule, but leave the non-vendor prefixed version whatever case is passed in. Thoughts?
There was a problem hiding this comment.
Thanks. I was rather proud of that little bit of code. You brought up a good point and I totally agree. Fixed.
There was a problem hiding this comment.
obj._setPrefixedCSSRule looks identical to obj._getPrefixedCSSRule except for the return or set.
Suggest you have a single function to build the ruleset and then use that in get and set. It should save quite a bit of space and not have duplicate code around.
…ule capitalization.
|
Reviewed code, tested using provided example and Kitchen Sink. Pretty solid. Request accepted. |
| (animation.opaque === false || animation.visible === false) && (_style.opacity = 0.0); | ||
|
|
||
| // Set the position and size properties | ||
| isDefined(animation.top) && (_style.top = animation.top + "px"); |
There was a problem hiding this comment.
FYI values coming into Titanium can have units. px, dp, sp, in, mm, cm, %
… positions were set incorrectly.
|
Code re-reviewed. Request accepted |
|
Code re-reviewed and re-tested. Looks good! Request accepted. |
Timob 6017 Mobile web animation.
No description provided.