[TIMOB-23992] iOS: Disable context menu and contextual menu in Ti.UI.WebView #8488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansemannn
changed the title
|
test this please |
sgtcoolguy
suggested changes
Oct 11, 2016
| // Disable user selection and the attached callout | ||
| BOOL disableSelection = [TiUtils boolValue:[[self proxy] valueForKey:@"disableSelection"] def:NO]; | ||
| // Disable the context menu when selecting text | ||
| BOOL disableSelection = [TiUtils boolValue:[[self proxy] valueForKey:@"disableContextMenu"] def:NO]; |
There was a problem hiding this comment.
might want to rename the variable to match the property: disableContextMenu - rather than disableSelection.
There was a problem hiding this comment.
Agree. The Travis job is running for 2 days now, hopefully it's re-triggered correctly after the commit.
|
Hey Chris, so I finally updated the docs to have the Android part documented as well (not done in #8494). We should be cool now! Please squash-merge or I'll rebase the commits, it became a bit messy at the end, sorry for that! |
sgtcoolguy
approved these changes
Nov 7, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-23992