removed isDragging check and added boolean dragging to event object #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: btknorr has already signed the CLA. |
|
I'm afraid we have to reject this request. It breaks parity with Android and would cause the "scroll" event to fire frequently, even when not dragging the view (a view "did" scroll whenever the displayed content within the frame changes, which could be very frequently; 'isDragging' checks "the user has begun scrolling the content", according to the iOS documentation). However, we understand that this is an important feature requested by the community and will be evaluating an alternative to this solution in the near term. |
jpl-mac
referenced
this pull request
in jpl-mac/titanium_mobile
Jun 29, 2012
TIMOB-9306: Blackberry: add a universal logging mechanism for tibb [Issues Fixed] TIMOB-9306: Blackberry: add a universal logging mechanism for tibb [Added] NativeLoggerInterface.h NativeLoggerObject.cpp NativeLoggerObject.h NativeLoggerWorker.cpp NativeLoggerWorker.h NativeMessageStrings.cpp NativeMessageStrings.h TiLogger.cpp TiLogger.h [Changes] NativeAbstractTextControlObject.cpp - switched to use N_DEBUG NativeObject.h - added N_TYPE_LOGGER - removed old Ti_DEBUG NativeObjectFactory.cpp - added N_TYPE_LOGGER TiUITableView.cpp - switched to use Ti_DEBUG TitaniumRuntime.cpp - initialize TiLogger Moved debug strings to central location Removed unused function TitaniumRuntime::Log Also moved the Native strings into NativeMessageStrings.h [Tests] Test 1: Use logger 1) Put some Ti_DEBUG and N_DEBUG statements in the code that will be run 2) Build tibb and verify there are no errors 3) Create, build, and run a new project 4) Verify the logging statements are in the app's log and are not intermingled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
I removed the check for scrollView.isDragging on TableView so that it fires like you would expect it too, and added the boolean "dragging" to the event - which is inline with the "scroll" event on a ScrollView. This allows the "scroll" event to be fired when a TableView is scrolled, not just when being dragged. It also allows us to fix the "pull to refresh" issues on devices <= iPhone 3G
Thanks,
Brian