[TIMOB-23493] Android: #append method in Ti.Filesystem.File

[frankieandone]

JIRA: https://jira.appcelerator.org/browse/timob-23493

[garymathews]

Use tabs

[garymathews]

Use tabs

[garymathews]

It's best to not modify the original formatting of the files you are making changes to; it's hard to review as I cannot distinguish the original code from the changes you have made.

[sgtcoolguy]

@fmerzadyan My comments from #8471 still apply. Appending using writers is incorrect and wasteful in terms of performance as well as may transform the contents. Please just copy bytes (for File) as you do with TiBlob.

Also, please try to avoid closing and re-opening new PRs for the same code/ticket. We lose history of the reviews and it becomes difficult to track between ticket and correct PR.

[sgtcoolguy]

@fmerzadyan There's a merge conflict that needs to be resolved; looks like somehow one of Gary's commits made it into your branch; and lastly, we need to update the yaml docs to indicate that append is now supported on android (apidoc/Titanium/Filesystem/File.yml)

[garymathews]

Why not just make use of the write methods that already exist with an append flag?

@Override
public boolean append(Object data) throws IOException
{
    try {
        if (data instanceof String) {
            write((String) data, true);
        } else if (data instanceof TiFileProxy) {
            // write((TiFileProxy) data, true); // implement an append flag into this
        } else if (data instanceof TiBlob) {
            write((TiBlob) data, true);
        }
        return true;
    } catch (IOException e) {
        Log.e(TAG, "Error appending: ", e);
    }
    return false;
}

[frankieandone]

If you're going that way then it would just be better to edit TiFileProxy instead because less changes would need to be made.

[garymathews]

You can just do this, there's no need for any other changes.

@Kroll.method
public boolean append(Object data)
{
    return write(new Object[]{data, true});
}

[frankieandone]

There was only 1 write method. The original write method had only one argument (Object[] args). I changed it so that it could take in append argument which is necessary. It keeps the original write exposed, the new write method not exposed and append is exposed too. But I'll be sure to change this one line.

[garymathews]

Titanium.Filesystem.write should already be exposed with the optional append parameter, so you can just make use of that 👍

[garymathews]

The args array contains the append Boolean, so there's no need to redefine it as a parameter. Which is why these changes aren't necessary.

[frankieandone]

I thought I removed that, my mistake.

[garymathews]

CR: PASS
FR: PASS

👍

[garymathews]

test this please