Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-24053] Android: Fix Ti.UI.TextField passwordMask when not editable #8530

Merged
merged 1 commit into from Oct 24, 2016

Conversation

garymathews
Copy link
Contributor

@garymathews garymathews commented Oct 21, 2016

  • Allow passwordMask to be set correctly when editable is set to false
TEST CASE
var win = Ti.UI.createWindow({backgroundColor: 'grey', layout: 'vertical'}),
    txt = Ti.UI.createTextField({value: 'hello', editable: false, passwordMask: true}),
    btn = Ti.UI.createButton({title: 'SHOW/HIDE'});

btn.addEventListener('click', function () {
    txt.passwordMask = !txt.passwordMask;
});

win.add(txt);
win.add(btn);
win.open();

JIRA TIcket

@garymathews garymathews added this to the 6.1.0 milestone Oct 21, 2016
@garymathews garymathews changed the title [TIMOB-24053] Fix Ti.UI.TextField passwordMask when not editable [TIMOB-24053] Android: Fix Ti.UI.TextField passwordMask when not editable Oct 21, 2016
@sgtcoolguy
Copy link
Contributor

I think the description is backwards, this fix is for when editable is false. In any case, I verified the broken behavior on an old SDK, and the fix with this PR. LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants