[TIMOB-3408] iOS: Support justified text-align in Labels, Buttons and TextFields #8562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgtcoolguy
suggested changes
Oct 31, 2016
| @@ -412,26 +412,9 @@ -(void)setVerticalAlign_:(id)align | |||
| -(void)setTextAlign_:(id)align | |||
| { | |||
| button = [self button]; | |||
| NSTextAlignment alignment = NSTextAlignmentNatural; | |||
There was a problem hiding this comment.
Note that this actually does change behavior here. If the user specified null/undefined/ or a bad int value, we'd default to NSTextAlignmentNatural, while we can no longer specify any value to get that setting now. We may want to expose a "natural" constant value as well?
There was a problem hiding this comment.
Agree. I'd rather change this constant to NSTextAlignmentNatural though. They look the same, but NSTextAlignmentNatural is the native way to go and default since iOS 6.
vijaysingh-axway
approved these changes
Nov 6, 2016
sgtcoolguy
approved these changes
Nov 7, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-3408