[TIMOB-24085] iOS: Add ListItem subtitle colors #8565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sgtcoolguy I thought about unit-tests but couldn't think of one that makes sense here, since we "just" fill a dictionary of template values that could be anything else as well without crashing - since the only result can be seen in the UI. Hard to describe. |
|
I mean in this case the unit test would basically just be ensuring that the API exists- that the property exists on an instance of a ListItem for iOS, and that you can set String color values on it. Presumably you could also add some validation testing that it doesn't crash if you pass in null/undefined/integer/non-color string. |
vijaysingh-axway
approved these changes
Nov 3, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-24085