Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-24058] Android: Fix Ti.UI.TableViewRow backgroundSelectedColor and backgroundSelectedImage #8579

Merged
merged 1 commit into from Jan 3, 2017

Conversation

garymathews
Copy link
Contributor

  • Prevent setOnClickListener() from being set on the TiUILabel used by TableViewRow for the title
TEST CASE
var win = Ti.UI.createWindow(),
    rows = [];

for (var i = 0; i < 10; i++) {
    rows.push(Ti.UI.createTableViewRow({
        title: 'ROW #' + i,
        // backgroundSelectedImage: '/KS_nav_ui.png',
        backgroundSelectedColor: 'red',
        backgroundColor: 'blue',
        height: 50
    }));
}

win.add(Ti.UI.createTableView({data: rows, separatorColor: 'black'}));
win.open();

JIRA Ticket

@garymathews garymathews added this to the 6.1.0 milestone Nov 3, 2016
@hansemannn hansemannn changed the title [TIMOB-24058] Fix Ti.UI.TableViewRow backgroundSelectedColor and backgroundSelectedImage [TIMOB-24058] Android: Fix Ti.UI.TableViewRow backgroundSelectedColor and backgroundSelectedImage Nov 11, 2016
@frankieandone
Copy link
Contributor

frankieandone commented Nov 28, 2016

Do you think this would be better?

if (!options.containsKey(TiC.PROPERTY_TOUCH_ENABLED)) {
    setProperty(TiC.PROPERTY_TOUCH_ENABLED, false);
}

User may want to set touchEnabled to true otherwise default in this case would be false?

@frankieandone
Copy link
Contributor

Or even defaultValues.put(TiC.PROPERTY_TOUCH_ENABLED, false); in constructor?

@garymathews
Copy link
Contributor Author

Nice catch! 😃

@garymathews
Copy link
Contributor Author

@fmerzadyan Updated PR

@frankieandone
Copy link
Contributor

CR and FT PASSED

@frankieandone frankieandone merged commit 9188fa2 into tidev:master Jan 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants