New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIMOB-6488] Adding a file property to Database. #860
Conversation
Conflicts: apidoc/Titanium/Database/Database.yml demos/KitchenSink/Resources/examples/database.js iphone/Classes/TiDatabaseProxy.m
Functional test iPod 3GT iOS 5.0.1. No regressions should be introduced by this new feature, but KitchenSink for 1.7 did change. APPROVED. |
@@ -44,5 +44,5 @@ FIELD_TYPE_STRING[int]: constant for requesting a column's value returned in str | |||
FIELD_TYPE_INT[int]: constant for requesting a column's value returned in integer form. | |||
FIELD_TYPE_FLOAT[int]: constant for requesting a column's value returned in float form. | |||
FIELD_TYPE_DOUBLE[int]: constant for requesting a column's value returned in double form. | |||
|
|||
file[Ti.FileSystem.File]: Returns a object representing the database itself.(NOTE: not supported on Android.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably say "iOS only" instead of "not supported on android", also the note in the parentheses is following the period, without a space (but it should probably be a part of the sentence)
@@ -44,5 +44,5 @@ FIELD_TYPE_STRING[int]: constant for requesting a column's value returned in str | |||
FIELD_TYPE_INT[int]: constant for requesting a column's value returned in integer form. | |||
FIELD_TYPE_FLOAT[int]: constant for requesting a column's value returned in float form. | |||
FIELD_TYPE_DOUBLE[int]: constant for requesting a column's value returned in double form. | |||
|
|||
file[Ti.FileSystem.File]: Returns a object representing the database itself .(iOS only) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spacing around the period should be fixed. Also, I think that tdoc doesn't support explicit typing like this; you might need to say that it returns an 'object' and explicitly specify the return type in the description with the tdoc semantics of [[Titanium.Filesystem.File]]
.
Doc changes reviewed; look OK. APPROVED. |
Doc looks good, Approved |
[TIMOB-6488] Adding a file property to Database.
Testing instruction in JIra ...