TIMOB-24082 Android: TiSound MediaPlayer.setDataSource error #8607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankieandone
force-pushed
the
timob-24082
branch
from
56d1a79
to
fd57857
Compare
frankieandone
force-pushed
the
timob-24082
branch
from
a3f1f1a
to
4371e30
Compare
garymathews
reviewed
Nov 15, 2016
| @@ -104,7 +104,7 @@ protected void initializeAndPlay() | |||
| } | |||
| // Why mp.setDataSource(afd) doesn't work is a problem for another day. | |||
| // http://groups.google.com/group/android-developers/browse_thread/thread/225c4c150be92416 | |||
| mp.setDataSource(afd.getFileDescriptor(), afd.getStartOffset(), afd.getLength()); | |||
| mp.setDataSource(afd.getFileDescriptor(), afd.getStartOffset()+1, afd.getLength()); | |||
There was a problem hiding this comment.
This issue seems specific to 4.4.2, you should encapsulate your solution to that version. Also, what is the value of getStartOffset() and why does it need +1 to work? Try with a few more audio files, see if you can reproduce the issue again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-24082
AssetFileDescriptor gives wrong startOffset value which causes media player to crash on Android 4.4.2 device