[TIMOB-23997] Reverted bad CommonJS module logic #8623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d iOS build. The original changes were incorrect and the fix was not applicable. So the best course of action is to revert.
|
APPROVED |
|
@cb1kenobi This has broken our support for commonJS modules that don't use the legacy naming where there has to be a JS file named the exact same as the module id. I specifically did not approve the PR because of this concern. This has broken our test suite which validates that we can handle nom-style modules. I need to revert this. |
|
@sgtcoolguy Correct. Your PR should have never been merged due to bad logic. I submitted a fix, but it was never approved, so I reverted it all back to pre-6.0.0. I'm happy you re-submitted #8648 and #8649 so now you can fix it to be correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-23997