TIMOB-6398 prop() #865
Merged
TIMOB-6398 prop() #865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…jects. Updated button to use the new mechanisms.
…mplemented button using it.
…tivity indicator.
…e into timob-6398
…n functionality. Updated all files that need props.
| get: function(){return obj.dom.style.backgroundPositionX;}, | ||
| set: function(val){obj.dom.style.backgroundPositionX = val + "px"} | ||
| set: function(val){return obj.dom.style.backgroundPositionX = val + "px"} | ||
| }); |
There was a problem hiding this comment.
This is more of a note for when redo the UI architecture, but this setter would break if val is something like "50px"
|
Code reviewed. Request accepted |
…utput of unimplemented locale functions.
…build script AGAIN. Ugh.
…build script AGAIN.
…Fixed extra windows opened by analytics. Fixed bug with capitalize function.
|
Reviewed and accepted |
|
Reviewed and accepted. @cb1kenobi and @Mindelusions tested this extensively. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements an internal-only function prop() that defines properties of the API classes.