[TIMOB-23848] iOS: Ti.Media add focus methods and properties #8662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansemannn
requested changes
Dec 6, 2016
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Some issues:
- Put the square brackets in the same line as the if-statement (
if (exp) {), same infor (expr) { - Put the configuration in the setter of the property, e.g.
- (void)setFlashMode:(id)valueand handle it there - Provide a getter, e.g.
- (id)flashModeas well - I'm curious if setting the
AVCaptureDevicewill work here, because we don't use theAVFoundationcamera API's but theUIImagePickerControllerAPI's
| constants: Titanium.Media.FOCUS_MODE_* | ||
| type: Number | ||
| default: Depends on camera | ||
| platforms: [android, iphone, ipad] |
There was a problem hiding this comment.
You don't need to specify the platforms if all three are supported. It will use all by default. Same for the other docs as well.
| summary: Constant to indicate focus mode of camera. | ||
| constants: Titanium.Media.FOCUS_MODE_* | ||
| type: Number | ||
| default: Depends on camera |
There was a problem hiding this comment.
Can we write something else here? It doesn't really help the developer. So either more infos on how it depends on the camera or leave it out and add a link to the Apple docs in the description value.
|
Added some comments, but it looks pretty good already! |
hansemannn
changed the title
|
Closing this PR as it will be part of the camera-module. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.appcelerator.org/browse/TIMOB-23848