[TIMOB-24069] Fixed pairing of ios and watch sims that has been aroun… #8667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d since Xcode 8 where you can't unpair certain ios and watch sims. [TIMOB-24136] Removed dependency on 'simctl getenv' which is broken in Xcode 8.2 beta and prevented knowning when an Xcode 8.2 sim has launched. Updated to ioslib 1.1.0. Major surgury to the iOS build to move the tiapp.xml validation before the --device-id validation. Also cleaned up min ios version and device family handling.
hansemannn
reviewed
Dec 8, 2016
| @@ -20,6 +22,7 @@ const mkdirp = require('mkdirp'); | |||
| const net = require('net'); | |||
| const path = require('path'); | |||
| const readPlist = require('./utilities').readPlist; | |||
| const simctl = require('./simctl'); | |||
There was a problem hiding this comment.
File not commited? Could not find it in node_modules/ioslib/lib/
There was a problem hiding this comment.
It was not committed because last October a line was added to the .gitignore to ignore everything [new] in the node_modules directory. I fixed it.
|
@cb1kenobi @cheekiatng FT looks good to me 🚀 |
|
APPROVED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.appcelerator.org/browse/TIMOB-24069
[TIMOB-24069] Fixed pairing of ios and watch sims that has been around since Xcode 8 where you can't unpair certain ios and watch sims.
https://jira.appcelerator.org/browse/TIMOB-24136
[TIMOB-24136] Removed dependency on 'simctl getenv' which is broken in Xcode 8.2 beta and prevented knowning when an Xcode 8.2 sim has launched.
Updated to ioslib 1.1.0.
Major surgury to the iOS build to move the tiapp.xml validation before the --device-id validation. Also cleaned up min ios version and device family handling.