New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIMOB-24192] Android: Implement Ti.UI.PickerRow getColor() and setColor() #8669
Conversation
b7540d9
to
8abf664
Compare
@@ -29,6 +30,18 @@ public PickerRowProxy() | |||
} | |||
|
|||
@Kroll.getProperty @Kroll.method | |||
public String getColor() | |||
{ | |||
return (String)getProperty(TiC.PROPERTY_COLOR); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a space like so return (String) getProperty(TiC.PROPERTY_COLOR);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The formatting of casts is inconsistent throughout, so it's down to personal preference.
} | ||
|
||
@Kroll.setProperty @Kroll.method | ||
public void setColor(String value) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could use color
instead of value
? Maybe value
was used in setTitle
to remove ambiguity as title
already exists as field? Your call.
Otherwise, looks good to merge!
8abf664
to
4ada642
Compare
CR and FT PASSED |
CR and FT PASSED |
setColor()
andgetColor()
forTitanium.UI.PickerRow
TEST CASE
JIRA Ticket