Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-24231][TIMOB-24232] Android: Fix Android module build compatibility #8703

Merged
merged 1 commit into from Feb 9, 2017

Conversation

garymathews
Copy link
Contributor

@garymathews garymathews commented Dec 20, 2016

  • Verify build architectures before building
  • Clean generated/jni directory before rebuild
  • Warn if armeabi is a target architecture
  • Ignore incompatible native libraries if they are not set in the manifest
TEST CASE
appc ti sdk select 5.5.1.GA
appc new -t timodule -n testModule --id com.test.module -p android
cd testModule/android
appc run -p android --build-only
# bulild successfully

# install latest 6.1.0 SDK
appc ti sdk install -b master
# apply my changes to the new SDK
appc ti sdk select
# press 1 to select the new SDK

# delete src/.../ExampleProxy.java
# update manifest to 'apiversion: 3' and 'minsdk: 6.0.0.GA'
appc run -p android --build-only
# display error regarding 'armeabi'
# remove 'armeabi' from the manifest

appc run -p android --build-only
# build successfully

TIMOB-24231
TIMOB-24232

@garymathews
Copy link
Contributor Author

test this please

@garymathews garymathews changed the title [TIMOB-24231][TIMOB-24232] Fix Android module build compatibility [TIMOB-24231][TIMOB-24232] Android: Fix Android module build compatibility Jan 12, 2017
@ahutton1217 ahutton1217 requested review from longton95 and removed request for longton95 January 30, 2017 18:48
@maggieaxway
Copy link
Contributor

CR FR passed

@lokeshchdhry lokeshchdhry requested review from lokeshchdhry and removed request for longton95 February 8, 2017 23:16
@lokeshchdhry
Copy link
Contributor

FR passed 👍
Checked it from CLI as well as studio.

Carried the following steps in CLI & studio:

  1. Built an android module using SDK 5.5.1.GA.
  2. Built/packaged it successfully.
  3. Built a local 6.1.0 for this PR & did a appc ti sdk select 6.1.0.
  4. Deleted src/.../ExampleProxy.java.
  5. Updated manifest to 'apiversion: 3' and 'minsdk: 6.0.0.GA'.
  6. Built/packaged it & it failed with:
[ERROR] : Architecture 'armeabi' is not supported by Titanium SDK 6.1.0
[ERROR] : Please remove this architecture from the manifest.
  1. Removed armeabi from the manifest.
  2. Built/packaged again successfully.

@lokeshchdhry lokeshchdhry merged commit 54e2cdd into tidev:master Feb 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants