[TIMOB-23802] Android: expose sustainedPerformancemode for future development #8709

frankieandone · 2016-12-21T23:57:59Z

Added property and updated docs for future reference. Feature is currently only available on Android 7 Nexus 6P + API docs/dev is seems premature, experimental and subject to changes. See Android docs for info

JIRA: https://jira.appcelerator.org/browse/TIMOB-23802

hansemannn · 2016-12-22T13:26:49Z

apidoc/Titanium/UI/Window.yml

+        summary: true to enable sustained performance mode
+        type: Boolean
+    since: "6.1.0"
+    platforms: [android]


You don't need the custom getter and setter, they are auto-generated in the docs

hansemannn · 2016-12-22T13:27:34Z

android/modules/ui/src/java/ti/modules/titanium/ui/WindowProxy.java

@@ -164,6 +166,10 @@ protected void handleOpen(KrollDict options)
 	            topActivity.startActivity(intent);
 	        }
 	    }
+
+	    if (options.containsKey(TiC.PROPERTY_SUSTAINED_PERFORMANCE_MODE)) {
+	        setPropertyAndFire(TiC.PROPERTY_SUSTAINED_PERFORMANCE_MODE, options.getBoolean(TiC.PROPERTY_SUSTAINED_PERFORMANCE_MODE));


So where is the property used on the native side? I only see the proxy-methods so far. WiP?

I was afraid of adding it currently because that feature is only available in Android API 24 and not 23. We only currently support 23. But if I were to add it, it would be in the thread state methods in TiBaseActivity

Just encapsulate it, something like:

if (Build.VERSION.SDK_INT == 24 && isSustainedPerformanceModeSupported()) { ... } else { Log.w(TAG, "sustainedPerformanceMode is not supported on this version of Android"); }

Alright I'll see 👍

I'd prefer >= 24 but yeah :-)

@hansemannn nice catch! :)

hansemannn · 2016-12-22T13:28:16Z

apidoc/Titanium/UI/Window.yml

@@ -800,6 +815,14 @@ properties:
    since: "3.1.3"
    platforms: [iphone,ipad]

+  - name: sustainedPerformanceMode
+    summary: Maintain a sustainable level of performance


Missing "." at the end.

hansemannn · 2016-12-22T13:28:38Z

apidoc/Titanium/UI/Window.yml

+  - name: sustainedPerformanceMode
+    summary: Maintain a sustainable level of performance
+    description: |
+        Performance can fluctuate dramatically for long-running apps, because the system throttles system-on-chip engines as device components reach their temperature limits. This fluctuation presents a moving target for app developers creating high-performance, long-running apps. Setting this feature to true will set sustained performance mode for the corresponding window. If property is undefined then it defaults to false. IMPORTANT NOTE: feature is only available on supported devices and awaiting for further API development by Google. See [Android docs](https://developer.android.com/about/versions/nougat/android-7.0.html#sustained_performance_api) for further info.


Break into multiple lines

frankieandone · 2016-12-22T23:48:20Z

Also, I suggest adding isSustainedPerformanceModeSupported() to check if device supports feature. See: Android docs: PowerManager.

Footnote: adding Android docs: Consistent Performance for future reference.

hansemannn · 2016-12-27T15:54:52Z

apidoc/Titanium/UI/Window.yml

+        Setting this feature to true will set sustained performance mode for the corresponding window. If property is undefined then it defaults to false.
+
+        Note: feature is only available on supported devices and functionality is experimental and subject to change in future releases. See [Android docs](https://developer.android.com/about/versions/nougat/android-7.0.html#sustained_performance_api) and [Google VR docs](https://developers.google.com/vr/android/ndk/jni/reference/com/google/vr/ndk/base/AndroidCompat.html#setSustainedPerformanceMode(Activity, boolean)) for further info.
+    type: Boolean


The lines are still too long. Example of proper line breaks:

Performance can fluctuate dramatically for long-running apps, because the system throttles system-on-chip engines as device components reach their temperature limits. This fluctuation presents a moving target for app developers creating high-performance, long-running apps. Setting this feature to true will set sustained performance mode for the corresponding window. If the property is undefined it defaults to false. Note: feature is only available on supported devices and functionality is experimental and subject to change in future releases. See the [Android docs](https://developer.android.com/about/versions/nougat/android-7.0.html#sustained_performance_api) and [Google VR docs](https://developers.google.com/vr/android/ndk/jni/reference/com/google/vr/ndk/base/AndroidCompat.html#setSustainedPerformanceMode(Activity, boolean)) for further info.

Note that I did not break the last names, since the links cause the length there

hansemannn · 2017-01-04T10:58:43Z

apidoc/Titanium/UI/Window.yml

+        subject to change in future releases. See [Android docs](https://developer.android.com/about/versions/nougat/android-7.0.html#sustained_performance_api) and [Google VR docs](https://developers.google.com/vr/android/ndk/jni/reference/com/google/vr/ndk/base/AndroidCompat.html#setSustainedPerformanceMode(Activity, boolean)) for further info.
+    type: Boolean
+    since: "6.1.0"
+    platforms: [android]


Can you add osver: {android: {min: "7.0"}} ? Rest looks cool to me!

garymathews · 2017-11-02T17:51:09Z

Continued by #9582

timob-23082 expose sustained performance mode for future development

7df6a43

frankieandone added android docs feature labels Dec 21, 2016

frankieandone added this to the 6.1.0 milestone Dec 21, 2016

frankieandone assigned garymathews Dec 21, 2016

hansemannn requested changes Dec 22, 2016

View reviewed changes

frankieandone force-pushed the timob-23802 branch from 1c004d7 to f0252eb Compare December 22, 2016 23:10

timob-23802 updated doc

69ac9ba

frankieandone force-pushed the timob-23802 branch from e9340a4 to 69ac9ba Compare December 22, 2016 23:40

hansemannn reviewed Dec 27, 2016

View reviewed changes

timob-23802 added sustain mode into activity and formatted window.yml

8a06c59

frankieandone force-pushed the timob-23802 branch from 96bf90d to 8a06c59 Compare January 3, 2017 23:01

hansemannn reviewed Jan 4, 2017

View reviewed changes

timob-23802 added android min version to window.yml

5f43a7b

hansemannn approved these changes Mar 20, 2017

View reviewed changes

hansemannn requested a review from garymathews March 20, 2017 21:15

Merge branch 'master' into timob-23802

115eca5

hansemannn modified the milestones: 6.1.0, 6.2.0 Jun 5, 2017

hansemannn modified the milestones: 7.0.0, 6.2.0 Aug 15, 2017

Merge branch 'master' into timob-23802

16adbe8

frankieandone mentioned this pull request Aug 25, 2017

(6_2_0)[TIMOB-23802] Android: expose sustainedPerformancemode for future development #9355

Closed

Frankie and others added 2 commits August 24, 2017 21:59

Update Window.yml

568c34e

Update Window.yml

8d06b34

garymathews mentioned this pull request Nov 2, 2017

[TIMOB-23802] Android: Implement sustained performance mode property #9582

Merged

garymathews closed this Nov 2, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TIMOB-23802] Android: expose sustainedPerformancemode for future development #8709

[TIMOB-23802] Android: expose sustainedPerformancemode for future development #8709

frankieandone commented Dec 21, 2016

hansemannn Dec 22, 2016

hansemannn Dec 22, 2016

frankieandone Dec 22, 2016

garymathews Dec 23, 2016 •

edited

frankieandone Dec 23, 2016

hansemannn Dec 27, 2016

garymathews Dec 27, 2016

hansemannn Dec 22, 2016

hansemannn Dec 22, 2016

frankieandone commented Dec 22, 2016

hansemannn Dec 27, 2016 •

edited

hansemannn Jan 4, 2017

garymathews commented Nov 2, 2017

[TIMOB-23802] Android: expose sustainedPerformancemode for future development #8709

[TIMOB-23802] Android: expose sustainedPerformancemode for future development #8709

Conversation

frankieandone commented Dec 21, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

garymathews Dec 23, 2016 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

frankieandone commented Dec 22, 2016

hansemannn Dec 27, 2016 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

garymathews commented Nov 2, 2017

garymathews Dec 23, 2016 •

edited

hansemannn Dec 27, 2016 •

edited